Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch numpy to fix issue with python3.7 #25755

Closed
vinklein mannequin opened this issue Jul 3, 2018 · 15 comments
Closed

Patch numpy to fix issue with python3.7 #25755

vinklein mannequin opened this issue Jul 3, 2018 · 15 comments

Comments

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jul 3, 2018

Following discussion #25680 comment:35

fix numpy's ​issue #10500.

Force to recythonize during numpy install.

CC: @jdemeyer

Component: packages: standard

Author: Vincent Klein

Branch/Commit: 9c0cb67

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/25755

@vinklein vinklein mannequin added this to the sage-8.3 milestone Jul 3, 2018
@vinklein

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jul 3, 2018

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jul 3, 2018

comment:4

@jdemeyer : you removed "when sage is run with python >= 3.7." from description.

Do you prefer to recythonize in every cases ?


New commits:

7a7cb17Trac #25755: Patch numpy to fix issue with ptyhon3.7

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jul 3, 2018

Commit: 7a7cb17

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2018

Changed commit from 7a7cb17 to 6e291b1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

6e291b1Trac #25755: update package version

@jdemeyer
Copy link

jdemeyer commented Jul 3, 2018

comment:6

Replying to @vinklein:

Do you prefer to recythonize in every cases ?

Yes because we should take advantage of Cython's improvements unconditionally.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

48ceb84Trac #25755: recythonized numpy in every case

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2018

Changed commit from 6e291b1 to 48ceb84

@vinklein vinklein mannequin added t: bug and removed t: enhancement labels Jul 3, 2018
@jdemeyer
Copy link

jdemeyer commented Jul 4, 2018

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

jdemeyer commented Jul 4, 2018

@jdemeyer
Copy link

jdemeyer commented Jul 4, 2018

Changed commit from 48ceb84 to 9c0cb67

@jdemeyer
Copy link

jdemeyer commented Jul 4, 2018

comment:12

Added actual Cython dependency on Numpy.


New commits:

9c0cb67Add cython as dependency of numpy

@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/jdemeyer/patch_numpy_to_fix_issue_with_python3_7 to 9c0cb67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants