Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch scipy to fix issue with python3.7 #25759

Closed
vinklein mannequin opened this issue Jul 3, 2018 · 11 comments
Closed

Patch scipy to fix issue with python3.7 #25759

vinklein mannequin opened this issue Jul 3, 2018 · 11 comments

Comments

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jul 3, 2018

Installing scipy 0.19.1 (source release) with python 3.7 generate multiple errors of this kind:

scipy/cluster/_vq.c: In function ‘__Pyx__ExceptionSave’:
    scipy/cluster/_vq.c:9728:19: error: ‘PyThreadState {aka struct _ts}’ has no member named ‘exc_type’
         *type = tstate->exc_type;
                       ^
    scipy/cluster/_vq.c:9729:20: error: ‘PyThreadState {aka struct _ts}’ has no member named ‘exc_value’
         *value = tstate->exc_value;
                        ^
    scipy/cluster/_vq.c:9730:17: error: ‘PyThreadState {aka struct _ts}’ has no member named ‘exc_traceback’
         *tb = tstate->exc_traceback;

This can be fixed by forcing *.pyx files to be recythonized.

Component: packages: standard

Author: Vincent Klein

Branch/Commit: u/vklein/patch_scipy_to_fix_issue_with_python3_7 @ 158885c

Issue created by migration from https://trac.sagemath.org/ticket/25759

@vinklein vinklein mannequin added this to the sage-8.3 milestone Jul 3, 2018
@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jul 3, 2018

@jdemeyer
Copy link

jdemeyer commented Jul 3, 2018

comment:2

Do you have to remove cythonize.dat? If so, document why.


New commits:

6df21c3Trac #25759: Force scipy to cythonize *.pyx files
bb3787dTrac #25759: update package version

@jdemeyer
Copy link

jdemeyer commented Jul 3, 2018

Commit: bb3787d

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jul 3, 2018

comment:3

from ​6df21c3 comment:

- Remove cythonize.dat file : That contains the hashcode
used to define if the *.pyx files has been modified

You mean in file fix-scipy-0.19.1-for-python37.patch ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

158885cTrac #25759: add some doc in .patch file

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2018

Changed commit from bb3787d to 158885c

@vinklein vinklein mannequin added the s: needs review label Jul 4, 2018
@jdemeyer
Copy link

comment:6

If you really must remove cythonize.dat, I would do it with a rm -f instead of a patch. The problem with a patch is that it must be updated every time we upgrade scipy.

@jdemeyer
Copy link

comment:7

Maybe we should try #24766 first, that might also fix the issue.

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jul 23, 2018

comment:8

Replying to @jdemeyer:

Maybe we should try #24766 first, that might also fix the issue.

Yes ! #24766 works.

@vinklein vinklein mannequin removed this from the sage-8.3 milestone Jul 23, 2018
@jdemeyer
Copy link

comment:9

Sorry for the wasted effort Vincent.

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jul 23, 2018

comment:10

No problem ! Upgrading is better than patching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant