Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding partition keyword for plot3d of graphs #25777

Closed
fchapoton opened this issue Jul 5, 2018 · 7 comments
Closed

adding partition keyword for plot3d of graphs #25777

fchapoton opened this issue Jul 5, 2018 · 7 comments
Labels
c: graphics p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@fchapoton
Copy link
Contributor

CC: @dcoudert

Component: graphics

Author: Frédéric Chapoton

Branch/Commit: 5c380e7

Reviewer: David Coudert, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25777
@fchapoton fchapoton added this to the sage-8.3 milestone Jul 5, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25777

@fchapoton
Copy link
Contributor Author

New commits:

5c380e7adding partition keyword for plot3d of graphs

@fchapoton
Copy link
Contributor Author

Commit: 5c380e7

@dcoudert
Copy link
Contributor

dcoudert commented Jul 5, 2018

comment:3

The code looks good, but I'm unfortunately unable to test it on my laptop (I'm blocked to 8.2.rc1 until I succeed to update my system). I tried to do X forwarding from a server but the jmol java stuff displays nothing while G.show() is working fine...

@tscrim
Copy link
Collaborator

tscrim commented Jul 5, 2018

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jul 5, 2018

Reviewer: David Coudert, Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/chapoton/25777 to 5c380e7

@vbraun vbraun closed this as completed in cff00f0 Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graphics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @dcoudert