Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement graftal lace cellular automata #25797

Closed
tscrim opened this issue Jul 7, 2018 · 22 comments
Closed

Implement graftal lace cellular automata #25797

tscrim opened this issue Jul 7, 2018 · 22 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Jul 7, 2018

Following https://arxiv.org/abs/1805.11532, we implement graftal lace cellular automata (GLCA).

Depends on #25796

CC: @fchapoton

Component: dynamics

Keywords: cellular automata

Author: Travis Scrimshaw

Branch/Commit: bded57c

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/25797

@tscrim tscrim added this to the sage-8.3 milestone Jul 7, 2018
@tscrim
Copy link
Collaborator Author

tscrim commented Jul 7, 2018

Commit: d3db5b6

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 7, 2018

Branch: public/dynamics/glca-25797

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 7, 2018

New commits:

3a9f81dInitial implementation of elementary cellular automata.
d3db5b6Initial implementation of GLCAs.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2018

Changed commit from d3db5b6 to 82946c1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

16a49a0Merge branch 'develop' into public/dynamics/glca-25797
82946c1Adding glca.py to references.

@tscrim
Copy link
Collaborator Author

tscrim commented Oct 1, 2018

comment:3

This and #25796 are in the kinda-fun category of things to play with in Sage. If you have a few moments, I'd appreciate a review (but this is far from a priority, so feel free to ignore).

@tscrim tscrim modified the milestones: sage-8.3, sage-8.4 Oct 1, 2018
@fchapoton
Copy link
Contributor

comment:4

now the branch is red.

How are things going ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 29, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

70947deMerge branch 'public/dynamics/glca-25797' of git://trac.sagemath.org/sage into public/dynamics/glca-25797

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 29, 2020

Changed commit from 82946c1 to 70947de

@fchapoton
Copy link
Contributor

comment:6

Hello !

The raise "invalid rule" must be doctested.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 29, 2020

comment:7

Trivial rebase (just in the master reference file). I will add the doctests tomorrow when I get into my office.

I am doing okay. Australia is thinking of starting to relax restrictions in a few weeks. How are things for you?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 29, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

af577a7Added tests for invalid rule.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 29, 2020

Changed commit from 70947de to af577a7

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 29, 2020

comment:9

Replying to @fchapoton:

The raise "invalid rule" must be doctested.

Done.

@fchapoton
Copy link
Contributor

comment:11

Here I'm doing ok too, sort of. Trying hard not to turn crazy.

Some more comments:

Pyflakes plugins is not happy.

Maybe use https://www.gnu.org/licenses/ in the header (with https)

What is the default behaviour of evolve : how many steps if number is None ?

Maybe the name András Kaszanyitzky should appear in the file itself ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 30, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

bded57cSome additional touchups.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 30, 2020

Changed commit from af577a7 to bded57c

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 30, 2020

comment:13

Replying to @fchapoton:

Pyflakes plugins is not happy.

Fixed.

Maybe use https://www.gnu.org/licenses/ in the header (with https)

Fixed, I think.

What is the default behaviour of evolve : how many steps if number is None ?

Fixed.

Maybe the name András Kaszanyitzky should appear in the file itself ?

I don't think this is necessary as there is a reference to the paper itself and I don't think there is a natural place to put it.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:14

ok, agreed. Good to go.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 30, 2020

comment:15

Thank you.

@vbraun
Copy link
Member

vbraun commented May 4, 2020

Changed branch from public/dynamics/glca-25797 to bded57c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants