Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage --info tries to write to SAGE_SPKG_SCRIPTS #25809

Closed
timokau opened this issue Jul 9, 2018 · 8 comments
Closed

sage --info tries to write to SAGE_SPKG_SCRIPTS #25809

timokau opened this issue Jul 9, 2018 · 8 comments
Labels
c: distribution p: major / 3 t: bug
Milestone
sage-8.3

Comments

@timokau
Copy link
Contributor

timokau commented Jul 9, 2018

sage --info currently unnecessarily needs write access to SAGE_SPKG_SCRIPTS, which typically will be in a read-only or root owned location for distros. This fixes that by moving the mkdir commands to the appropriate section of the file, after --info has exited.

CC: @embray @kiwifb

Component: distribution

Author: Timo Kaufmann

Branch/Commit: f02714d

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/25809
@timokau timokau added this to the sage-8.3 milestone Jul 9, 2018
@timokau
Copy link
Contributor Author

timokau commented Jul 9, 2018

comment:1

CC'ing fbissey since you'll probably have the same error on gentoo.

@timokau
Copy link
Contributor Author

timokau commented Jul 9, 2018

Changed branch from u/gh-timokau/ino-no-side-effect to u/gh-timokau/info-no-side-effect

@timokau
Copy link
Contributor Author

timokau commented Jul 9, 2018

Commit: f02714d

@timokau
Copy link
Contributor Author

timokau commented Jul 9, 2018

New commits:

f02714dDon't attempt to create dirs when showing pkg info

@timokau
Copy link
Contributor Author

timokau commented Jul 9, 2018

comment:3

On a related note, it might be nice to make the sage installation read-only when doctesting in CI.

@embray
Copy link
Contributor

embray commented Jul 10, 2018

Reviewer: Erik Bray

@embray
Copy link
Contributor

embray commented Jul 10, 2018

comment:5

Yikes, I didn't even know about sage --info. Yes, this definitely makes more sense.

@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/gh-timokau/info-no-side-effect to f02714d

@vbraun vbraun closed this as completed in 3ed549f Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: distribution p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@embray @vbraun @timokau