Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small cleanup in jacobian_generic.py #25841

Closed
fchapoton opened this issue Jul 12, 2018 · 8 comments
Closed

small cleanup in jacobian_generic.py #25841

fchapoton opened this issue Jul 12, 2018 · 8 comments
Labels
c: algebraic geometry c: python3 p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@fchapoton
Copy link
Contributor

  • removal of _cmp_
  • add comparison doctest
  • pep and pyflakes

CC: @tscrim

Component: algebraic geometry

Keywords: richcmp

Author: Frédéric Chapoton

Branch/Commit: 7843f72

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25841
@fchapoton fchapoton added this to the sage-8.3 milestone Jul 12, 2018
@fchapoton
Copy link
Contributor Author

New commits:

7843f72small cleanup in jacobian_generic.py (pep, pyflakes, removal of `_cmp_`)

@fchapoton
Copy link
Contributor Author

Commit: 7843f72

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25841

@fchapoton
Copy link
Contributor Author

Changed keywords from none to richcmp

@fchapoton
Copy link
Contributor Author

comment:3

green bot

@tscrim
Copy link
Collaborator

tscrim commented Jul 12, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 12, 2018

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/chapoton/25841 to 7843f72

@vbraun vbraun closed this as completed in 42f2533 Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebraic geometry c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton