Allow with_bounds to work on non-facade posets

[deinst]

Currently with_bounds is not implemented on non-facade posets. This may or not be a good idea, as often one would want the elements in the old poset and the poset with bounds to be comparable, and therefore having facade=True, but the current behavior is surprising.

We should either document that with_bounds does not work with non-facade posets, or create an implementation

Component: combinatorics

Author: David Einstein

Branch/Commit: 3658311

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25846

[deinst]

Branch: u/deinst/fix_poset_with_bounds

[deinst]

Commit: d061ea0

[deinst]

New commits:

d061ea0

Allow with_bounds to work on non-facade posets

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:3

Trivial PEP8 thing:

-P = posets.PentagonPoset(facade = False)
+P = posets.PentagonPoset(facade=False)

Once changed, you can set a positive review on my behalf.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3658311

Fixed extra spaces in named parameter.

[sagetrac-git]

Changed commit from d061ea0 to 3658311

[deinst]

comment:5

Sorry, Thanks.

[fchapoton]

Changed author from David EInstein to David Einstein

[vbraun]

Changed branch from u/deinst/fix_poset_with_bounds to 3658311