Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LatticePoset: Optimize is_simple() #25847

Closed
jm58660 mannequin opened this issue Jul 12, 2018 · 7 comments
Closed

LatticePoset: Optimize is_simple() #25847

jm58660 mannequin opened this issue Jul 12, 2018 · 7 comments
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-8.4

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Jul 12, 2018

Very minor heuristic.

After P = posets.BooleanLattice(8) compare timings of P.congruence([[0, 1]]) and P.congruence([[0, 128]]) to understand the reason.

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: f314a96

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25847
@jm58660 jm58660 mannequin added this to the sage-8.4 milestone Jul 12, 2018
@jm58660 jm58660 mannequin added c: combinatorics labels Jul 12, 2018
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jul 12, 2018

Branch: u/jmantysalo/is_simple-bug

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jul 12, 2018

Commit: f314a96

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jul 12, 2018

New commits:

f314a96Add sort before computing congruences.

@jm58660 jm58660 mannequin added the s: needs review label Jul 12, 2018
@tscrim
Copy link
Collaborator

tscrim commented Jul 12, 2018

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jul 12, 2018

Reviewer: Travis Scrimshaw

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Aug 5, 2018

comment:4

Pathcbot failures, but they all seems to be marked with # optional - magma so I suppose they are not really because of this ticket.

@vbraun
Copy link
Member

vbraun commented Aug 29, 2018

Changed branch from u/jmantysalo/is_simple-bug to f314a96

@vbraun vbraun closed this as completed in e8fe666 Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
2 participants
@vbraun @tscrim