Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -C option and DESTDIR to make #25851

Closed
ChukwuemezieChristopherAneke mannequin opened this issue Jul 12, 2018 · 4 comments
Closed

Add -C option and DESTDIR to make #25851

ChukwuemezieChristopherAneke mannequin opened this issue Jul 12, 2018 · 4 comments

Comments

@ChukwuemezieChristopherAneke
Copy link
Mannequin

I have compiled dozens of programs but sagemaths compilation is not user friendly. It needs extra features to make compilation easier.
Three suggestions i want to make are:

  1. Add -C option to make
    for example:

cd ~/sage/build

make -C ~/sage/src

This allows a user to build out of tree from a dedicated build directory which they can create themselves. This way one does not have to worry about how the developers have configured make clean and make distclean which varies between Makefile's. A quick rm -rf build and one can start re-compiling if something goes wrong.

  1. Add DESTDIR option
    I like to convert my source code installs into RPM packages before installing it. This requires me to use the DESTDIR option to set up a staging directory for the installation. I tried this with sagemath and it seemed to split the installtion between this staging area and the --prefix

  2. Add make install
    I understand the decision to have make do both building and installing as it allows users to do both in one command (and its easier for developers). However this makes compiling rigid and causes problems when a user needs to customize their installation. For example, if one wishes to convert the source code directory to an RPM or DEB package.

These three suggestions can enhance the user experience.

Component: build

Keywords: make, make install, DESTDIR, make -C

Issue created by migration from https://trac.sagemath.org/ticket/25851

@ChukwuemezieChristopherAneke

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:2

This looks like a duplicate of several other tickets. See #21479 (./configure --prefix=...), #21469 (enable VPATH builds), #21495 (make install), #21566. What parts of this ticket are not covered by those?

@ChukwuemezieChristopherAneke

This comment has been minimized.

@embray
Copy link
Contributor

embray commented Jul 13, 2018

comment:4

Thanks for your interest in helping to improve Sage's build/install experience. These are all well-known issues and most of them either have good reasons for them, or are actively being worked on (including work I'm doing, e.g. in #24024). I am also working in several directions to increase the number of dependencies Sage can inherit from the system rather than building its own (see e.g. #24919--a very important enhancement that desperately needs review).

You seem well-versed in build/packaging issues, so if you'd like to help out I can definitely point you in the right direction for contributing to ongoing work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants