Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of free Zinbiel algebras #25880

Closed
fchapoton opened this issue Jul 19, 2018 · 10 comments
Closed

cleanup of free Zinbiel algebras #25880

fchapoton opened this issue Jul 19, 2018 · 10 comments

Comments

@fchapoton
Copy link
Contributor

full pep8, pyflakes and coverage

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: b2d12bc

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25880

@fchapoton fchapoton added this to the sage-8.4 milestone Jul 19, 2018
@fchapoton
Copy link
Contributor Author

Commit: e8705b6

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25880

@fchapoton
Copy link
Contributor Author

New commits:

e8705b6fixing details in zinbiel algebras : full pep8, pyflakes and coverage

@tscrim
Copy link
Collaborator

tscrim commented Jul 19, 2018

comment:2

A while-we-are-at-it: can you change the header to use the standard copyright?

Bikeshedding: I find it better to break the 80 char/line guideline for code to avoid small breaks like this:

-        return super(FreeZinbielAlgebra, cls).__classcall__(cls, R, n, tuple(names))
+        return super(FreeZinbielAlgebra, cls).__classcall__(cls, R, n,
+                                                            tuple(names))

Bikeshedding nitpick:

-        - ``x`` and ``y`` -- two words
+        - ``x``, ``y`` -- two words

If you disagree with my comments, then I will be happy to set this to a positive review.

@tscrim
Copy link
Collaborator

tscrim commented Jul 19, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

b2d12bcsome suggested details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2018

Changed commit from e8705b6 to b2d12bc

@fchapoton
Copy link
Contributor Author

comment:4

Thanks for the review, Travis. All done, I hope.

@tscrim
Copy link
Collaborator

tscrim commented Jul 19, 2018

comment:5

Thank you. LGTM.

@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/chapoton/25880 to b2d12bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants