New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup of free Zinbiel algebras #25880
Comments
Commit: |
Branch: u/chapoton/25880 |
New commits:
|
comment:2
A while-we-are-at-it: can you change the header to use the standard copyright? Bikeshedding: I find it better to break the 80 char/line guideline for code to avoid small breaks like this: - return super(FreeZinbielAlgebra, cls).__classcall__(cls, R, n, tuple(names))
+ return super(FreeZinbielAlgebra, cls).__classcall__(cls, R, n,
+ tuple(names)) Bikeshedding nitpick: - - ``x`` and ``y`` -- two words
+ - ``x``, ``y`` -- two words If you disagree with my comments, then I will be happy to set this to a positive review. |
Reviewer: Travis Scrimshaw |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Thanks for the review, Travis. All done, I hope. |
comment:5
Thank you. LGTM. |
Changed branch from u/chapoton/25880 to |
full pep8, pyflakes and coverage
CC: @tscrim
Component: combinatorics
Author: Frédéric Chapoton
Branch/Commit:
b2d12bc
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/25880
The text was updated successfully, but these errors were encountered: