Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing of p-adic extensions #25908

Closed
xcaruso opened this issue Jul 23, 2018 · 33 comments
Closed

Printing of p-adic extensions #25908

xcaruso opened this issue Jul 23, 2018 · 33 comments

Comments

@xcaruso
Copy link
Contributor

xcaruso commented Jul 23, 2018

We make the print representation of p-adic extensions shorter and clearer (in order to prepare #23218).

For example, the different outputs below from before this ticket:

sage: R.<a> = ZqCR(25, 40); R
Unramified Extension in a defined by x^2 + 4*x + 2
with capped relative precision 40 over 5-adic Ring

sage: R.<a> = ZqCA(25, 40); R
Unramified Extension in a defined by x^2 + 4*x + 2
with capped absolute precision 40 over 5-adic Ring

sage: R.<a> = ZqFM(25, 40); R
Unramified Extension in a defined by x^2 + 4*x + 2
of fixed modulus 5^40 over 5-adic Ring

sage: R.<a> = ZqFP(25, 40); R
Unramified Extension in a defined by x^2 + 4*x + 2
with floating precision 40 over 5-adic Ring

become the same shorter outpout after this ticket:

sage: R.<a> = ZqCR(25, 40); R
5-adic Unramified Extension Ring in a defined by x^2 + 4*x + 2

sage: R.<a> = ZqCA(25, 40); R
5-adic Unramified Extension Ring in a defined by x^2 + 4*x + 2

sage: R.<a> = ZqFM(25, 40); R
5-adic Unramified Extension Ring in a defined by x^2 + 4*x + 2

sage: R.<a> = ZqFP(25, 40); R
5-adic Unramified Extension Ring in a defined by x^2 + 4*x + 2

CC: @roed314 @slel

Component: padics

Keywords: printing, padicIMA

Author: Xavier Caruso

Branch/Commit: 648ea64

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/25908

@xcaruso xcaruso added this to the sage-8.4 milestone Jul 23, 2018
@roed314
Copy link
Contributor

roed314 commented Jul 23, 2018

Branch: u/roed/padic_printing

@roed314
Copy link
Contributor

roed314 commented Jul 23, 2018

New commits:

debf1fcCommit to make different from develop

@roed314
Copy link
Contributor

roed314 commented Jul 23, 2018

Commit: debf1fc

@roed314
Copy link
Contributor

roed314 commented Jul 23, 2018

Changed keywords from printing to printing, padicIMA

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 23, 2018

Changed branch from u/roed/padic_printing to u/caruso/padic_parent_printing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

25c86a6Change printing for p-adic extensions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2018

Changed commit from debf1fc to 25c86a6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2018

Changed commit from 25c86a6 to e74fe63

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

e74fe63Doctest for the helper method _extension_type

@roed314
Copy link
Contributor

roed314 commented Jul 23, 2018

comment:6

I get these failures:

sage -t src/sage/categories/pushout.py  # 1 doctest failed
sage -t src/sage/modular/overconvergent/genus0.py  # 4 doctests failed
sage -t src/sage/rings/padics/CA_template.pxi  # 6 doctests failed
sage -t src/sage/rings/padics/CR_template.pxi  # 6 doctests failed
sage -t src/sage/rings/padics/FM_template.pxi  # 6 doctests failed
sage -t src/sage/rings/padics/FP_template.pxi  # 6 doctests failed
sage -t src/sage/rings/polynomial/padics/polynomial_padic.py  # 2 doctests failed
sage -t src/sage/rings/polynomial/polynomial_element.pyx  # 1 doctest failed
sage -t src/sage/rings/finite_rings/finite_field_base.pyx  # 2 doctests failed
sage -t src/sage/rings/ring.pyx  # 1 doctest failed
sage -t src/sage/schemes/hyperelliptic_curves/hyperelliptic_generic.py  # 1 doctest failed
sage -t src/sage/schemes/elliptic_curves/padic_lseries.py  # 1 doctest failed
sage -t src/sage/schemes/hyperelliptic_curves/hyperelliptic_padic_field.py  # 1 doctest failed
sage -t src/sage/structure/parent.pyx  # 1 doctest failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2018

Changed commit from e74fe63 to 5c4e3a3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

5c4e3a3Fix doctest

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 23, 2018

comment:8

I've fixed the doctests.
The ticket is ready for review.

@xcaruso

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2018

Changed commit from 5c4e3a3 to 7c5c68c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

7c5c68cNotion of absolute and relative degree / ramification index / inertia degree

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

c722955Added/fixed doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2018

Changed commit from 7c5c68c to c722955

@roed314
Copy link
Contributor

roed314 commented Jul 24, 2018

Changed branch from u/caruso/padic_parent_printing to u/roed/padic_parent_printing

@roed314
Copy link
Contributor

roed314 commented Jul 24, 2018

comment:12

Looks good to me.


New commits:

c722955Added/fixed doctests

@roed314
Copy link
Contributor

roed314 commented Jul 24, 2018

Changed branch from u/roed/padic_parent_printing to u/caruso/padic_parent_printing

@roed314
Copy link
Contributor

roed314 commented Jul 24, 2018

Author: Xavier Caruso

@roed314
Copy link
Contributor

roed314 commented Jul 24, 2018

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Jul 24, 2018

Changed branch from u/caruso/padic_parent_printing to u/roed/padic_parent_printing

@roed314
Copy link
Contributor

roed314 commented Jul 24, 2018

Changed commit from c722955 to 8815d83

@roed314
Copy link
Contributor

roed314 commented Jul 24, 2018

New commits:

8815d83Fix typos

@slel

This comment has been minimized.

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 25, 2018

comment:15

Patchbot (on cygwin) complains. Let's try again.

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 26, 2018

Changed branch from u/roed/padic_parent_printing to u/caruso/padic_parent_printing

@roed314
Copy link
Contributor

roed314 commented Jul 26, 2018

Changed commit from 8815d83 to 648ea64

@roed314
Copy link
Contributor

roed314 commented Jul 26, 2018

comment:18

All tests pass for me. We can wait for the patchbot to see if there are plugin errors.


New commits:

648ea64"base field" / "base ring"

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 26, 2018

comment:19

If you agree, I give a positive review and open a new ticket for the pyflakes issues found by the patchbot.

@vbraun
Copy link
Member

vbraun commented Aug 7, 2018

Changed branch from u/caruso/padic_parent_printing to 648ea64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants