New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for integrable representation (#15806) to Lie methods thematic tutorial #25937
Comments
New commits:
|
Commit: |
Branch: public/tutorial-25937 |
Changed author from bump to Daniel Bump |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Once this is done, I can look at it for typos, and see how it looks from the perspective of somebody that's not an expert on this stuff. Would probably still need an expert to at least glance over it to make sure nothing is majorly wrong. |
comment:11
I would be glad to help review this ticket. Dan, were there sections you wanted me to write? Why have some titles changed from capitals to lower case letters? |
comment:12
I am also willing to help with either writing or reviewing too. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:48
That works. Thanks! I implemented the last 3 comments from Travis and pushed. New commits:
|
comment:49
No problem. Anyone else have any comments? (Kevin?) I am ready to set this to a positive review. |
comment:50
I have read the document one more time and found a few typos. After correcting them, I would agree to set this to a positive review. Thanks!! --The support of an integrable highest weight representation first paragraph: ---Sage methods for integrable representations first paragraph: A period is missing at the end of the last sentence. second paragraph: The sentence "Then we compute the string function at this weight, which we see agrees with the string function for the corresponding dominant maximal weight:" seems out of place. Could we delete it? A period is missing at the end of the displayed math in the sentence begin with "Reading what the OEIS..." The formulas of two string functions are not adequately aligned. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:52
I made Kyu-Hwan's corrections except this one:
I don't see the alignment problem. New commits:
|
comment:53
In the introduction to "Integrable Highest Weight Representations of Affine Lie algebras", there is still a missing link: weyl_character_ring |
comment:54
The link to the last OESIS 'OEIS sequence 128015' seems broken. Other than these last two link problems, I am also happy to set a positive review. |
comment:55
@tscrim it seems like enough other people have already gotten a chance to read through it. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:57
I am not sure what happened to the alignment problem. In any case, it disappeared, and I am happy with the current version. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:60
Should be marked as optional internet:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:62
This had a positive review. Per comment:60 I changed the oeis test to optional -- internet. I was unsure whether it is appropriate for me to put the positive review back so I changed it to needs review. |
Changed branch from public/tutorial-25937 to |
The IntegrableRepresentation code for working with integrable representations of affine Lie algebras is documented in the reference manual but not in the Lie Methods and Related Combinatorics thematic tutorial. This ticket is to add documentation to the thematic tutorial.
CC: @sagetrac-khlee @anneschilling @nthiery @tscrim @bsalisbury1 @kevindilks
Component: documentation
Keywords: sagedays@icerm
Author: Daniel Bump
Branch/Commit:
a9119bb
Reviewer: Anne Schilling, Kyu-Hwan Lee, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/25937
The text was updated successfully, but these errors were encountered: