Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitting_field should call the base ring's _splitting_field_univariate_polynomial #25938

Open
saraedum opened this issue Jul 26, 2018 · 11 comments

Comments

@saraedum
Copy link
Member

Currently, a polynomial's splitting_field() is only implemented for finite fields and number fields. This can not be easily extended by user provided constructions such as Henselizations, https://github.com/MCLF/henselization.

I'll also fix a bunch of documentation errors while I am at it…

Component: padics

Keywords: padicIMA

Author: Julian Rüth

Branch/Commit: u/saraedum/25938 @ f01d916

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/25938

@saraedum saraedum added this to the sage-8.4 milestone Jul 26, 2018
@saraedum

This comment has been minimized.

@saraedum
Copy link
Member Author

Branch: u/saraedum/25938

@saraedum
Copy link
Member Author

New commits:

f01d916splitting_field() calls _splitting_field_univariate_polynomial()

@saraedum
Copy link
Member Author

Commit: f01d916

@saraedum
Copy link
Member Author

Work Issues: is the patchbot happy?

@saraedum
Copy link
Member Author

comment:4

I only ran rudimentary doctests.

@saraedum
Copy link
Member Author

Changed keywords from none to padicIMA

@roed314
Copy link
Contributor

roed314 commented Jul 26, 2018

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Jul 26, 2018

Changed work issues from is the patchbot happy? to none

@roed314
Copy link
Contributor

roed314 commented Jul 26, 2018

comment:6

Looks good!

@vbraun
Copy link
Member

vbraun commented Aug 27, 2018

comment:7
sage -t --long src/sage/rings/number_field/number_field_base.pyx
**********************************************************************
File "src/sage/rings/number_field/number_field_base.pyx", line 423, in sage.rings.number_field.number_field_base.NumberField._splitting_field_univariate_polynomial
Failed example:
    L
Expected:
    Number Field in b with defining polynomial t^2 - 4*t + 6
Got:
    Number Field in b with defining polynomial t^2 + 2
**********************************************************************
1 item had failures:
   1 of   6 in sage.rings.number_field.number_field_base.NumberField._splitting_field_univariate_polynomial
    [79 tests, 1 failure, 1.55 s]
----------------------------------------------------------------------
sage -t --long src/sage/rings/number_field/number_field_base.pyx  # 1 doctest failed
----------------------------------------------------------------------

@mkoeppe mkoeppe removed this from the sage-8.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants