Python 3: sorting issue causing failure in koszul_complex.py

[jhpalmieri]

A sorting issue (TypeError: '>' not supported between instances of 'NoneType' and 'int') in multi_polynomial_ring_base.pyx causes a doctest failure in koszul_complex.py in Python 3.

CC: @fchapoton @tscrim

Component: python3

Author: John Palmieri

Branch/Commit: 4a6ff4e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25978

[jhpalmieri]

Branch: u/jhpalmieri/koszul-multi-polynomial

[jhpalmieri]

Commit: d8f9668

[jhpalmieri]

comment:2

The issue here is that terms can be None while total is an integer, and then Python 3 objects to if terms > total:.

---

New commits:

d8f9668

trac 25978: don't try to compare None with an int

[tscrim]

comment:4

I think it is good to put a comment in there explaining why this test is the way it is.

Also, I am presuming total >= 0 (otherwise, there would be a bug when terms = 0 and total < 0).

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4a6ff4e

trac 25978: add comment explaining the change.

[sagetrac-git]

Changed commit from d8f9668 to 4a6ff4e

[jhpalmieri]

comment:6

Replying to @tscrim:

I think it is good to put a comment in there explaining why this test is the way it is.

Sounds good.

Also, I am presuming total >= 0 (otherwise, there would be a bug when terms = 0 and total < 0).

total is defined by counts, total = self._precomp_counts(n, degree), and according to the documentation, total is a sum of cardinalities, so it had better be nonnegative.

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:7

Thanks.

[vbraun]

Changed branch from u/jhpalmieri/koszul-multi-polynomial to 4a6ff4e