Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision issue in conversion #25990

Closed
xcaruso opened this issue Aug 3, 2018 · 14 comments
Closed

Precision issue in conversion #25990

xcaruso opened this issue Aug 3, 2018 · 14 comments

Comments

@xcaruso
Copy link
Contributor

xcaruso commented Aug 3, 2018

sage: R.<a> = Zp(2).extension(x^3 - 2)
sage: K = R.fraction_field()
sage: u = K(1,10); u
1 + O(a^10)
sage: R(u)
1 + O(a^12)

CC: @roed314 @saraedum

Component: padics

Author: Xavier Caruso

Branch/Commit: b4ed236

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/25990

@xcaruso xcaruso added this to the sage-8.4 milestone Aug 3, 2018
@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 17, 2018

Branch: u/caruso/padic_extension_conversion

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 17, 2018

Commit: efde687

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 17, 2018

comment:2

Should be fixed... Needs review.


New commits:

efde687Handle precision correctly in DefPolyConversion

@roed314
Copy link
Contributor

roed314 commented Aug 17, 2018

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Aug 17, 2018

comment:3

Looks good once patchbot is happy.

@roed314
Copy link
Contributor

roed314 commented Aug 17, 2018

Author: Xavier Caruso

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 17, 2018

comment:4

Hum, still not completely fine:

sage: R.<a> = Zp(2).extension(x^3 - 2)
sage: K = R.fraction_field()
sage: u = R(1 + a^4 + a^5 + a^7 + a^8, 10); u
sage: K(u)
1 + a^4 + a^5 + a^7 + a^8 + O(a^10)
sage: R(K(u))
1 + a^4 + a^5 + a^7 + a^8 + O(a^9)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

b4ed236Handle precision even better

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2018

Changed commit from efde687 to b4ed236

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 17, 2018

comment:6

Should be fixed... Needs review (bis)

@roed314
Copy link
Contributor

roed314 commented Aug 17, 2018

comment:7

Seems like a reasonable fix. Once again, I'm happy if the patchbot is.

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 18, 2018

comment:8

A failure is reported but it has nothing to do with this ticket, I guess.

Set positive review if you agree.

@roed314
Copy link
Contributor

roed314 commented Aug 18, 2018

comment:9

I agree.

@vbraun
Copy link
Member

vbraun commented Aug 25, 2018

Changed branch from u/caruso/padic_extension_conversion to b4ed236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants