Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singular build with SAGE_DEBUG misses omalloc headers #26023

Closed
vbraun opened this issue Aug 7, 2018 · 9 comments
Closed

Singular build with SAGE_DEBUG misses omalloc headers #26023

vbraun opened this issue Aug 7, 2018 · 9 comments

Comments

@vbraun
Copy link
Member

vbraun commented Aug 7, 2018

Building singular with SAGE_DEBUG fails to install omalloc headers into local/include/omalloc/, which later causes pynac to fail

[...]
cc1plus: warning: unrecognized command line option '-Wno-parentheses-equality'
mv -f .deps/libpynac_la-inifcns_comb.Tpo .deps/libpynac_la-inifcns_comb.Plo
/usr/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -std=c++11 -DHAVE_CONFIG_H -I. -I..  -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/python2.7 -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/ -DOM_NDEBUG  -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wno-unused-parameter -Wno-unknown-pragmas -Wno-parentheses-equality   -O2 -g  -MT libpynac_la-mpoly-singular.lo -MD -MP -MF .deps/libpynac_la-mpoly-singular.Tpo -c -o libpynac_la-mpoly-singular.lo `test -f 'mpoly-singular.cpp' || echo './'`mpoly-singular.cpp
mv -f .deps/libpynac_la-inifcns_orthopoly.Tpo .deps/libpynac_la-inifcns_orthopoly.Plo
/usr/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -std=c++11 -DHAVE_CONFIG_H -I. -I..  -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/python2.7 -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/ -DOM_NDEBUG  -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wno-unused-parameter -Wno-unknown-pragmas -Wno-parentheses-equality   -O2 -g  -MT libpynac_la-mpoly.lo -MD -MP -MF .deps/libpynac_la-mpoly.Tpo -c -o libpynac_la-mpoly.lo `test -f 'mpoly.cpp' || echo './'`mpoly.cpp
libtool: compile:  g++ -std=c++11 -DHAVE_CONFIG_H -I. -I.. -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/python2.7 -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/ -DOM_NDEBUG -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wno-unused-parameter -Wno-unknown-pragmas -Wno-parentheses-equality -O2 -g -MT libpynac_la-mpoly-singular.lo -MD -MP -MF .deps/libpynac_la-mpoly-singular.Tpo -c mpoly-singular.cpp  -fPIC -DPIC -o .libs/libpynac_la-mpoly-singular.o
libtool: compile:  g++ -std=c++11 -DHAVE_CONFIG_H -I. -I.. -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/python2.7 -I/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/ -DOM_NDEBUG -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wno-unused-parameter -Wno-unknown-pragmas -Wno-parentheses-equality -O2 -g -MT libpynac_la-mpoly.lo -MD -MP -MF .deps/libpynac_la-mpoly.Tpo -c mpoly.cpp  -fPIC -DPIC -o .libs/libpynac_la-mpoly.o
In file included from /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/factory/factory.h:29,
                 from mpoly-singular.cpp:27:
/mnt/disk/home/buildslave-sage/slave/sage_git/build/local/include/omalloc/omalloc.h:14:10: fatal error: omalloc/omConfig.h: No such file or directory
 #include "omalloc/omConfig.h"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

Indeed:

[buildslave-sage@volker build]$ ll local/include/omalloc/
total 12
-rw-r--r--. 1 buildslave-sage buildslave-sage 10010 Aug  7 00:50 omalloc.h

Depends on #24735

CC: @jpflori @sagetrac-jakobkroeker

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/26023

@vbraun vbraun added this to the sage-8.4 milestone Aug 7, 2018
@jdemeyer
Copy link

jdemeyer commented Aug 8, 2018

comment:2

This whole omalloc business is really confusing to me...

See also Singular/Singular#534

@jpflori
Copy link

jpflori commented Aug 8, 2018

comment:3

IIRC Singular used to install stub headers when omalloc was disabled but that was a long time ago...

@jdemeyer
Copy link

jdemeyer commented Aug 8, 2018

comment:4

Maybe we should just stop trying to build Singular without omalloc?

@jpflori
Copy link

jpflori commented Aug 8, 2018

comment:5

Is there still an xalloc directory used when omalloc is not?
The omConfig part is reminiscent of #17254 comment:381

@jdemeyer
Copy link

jdemeyer commented Aug 8, 2018

comment:6

Replying to @jpflori:

Is there still an xalloc directory used when omalloc is not?

Sorry, I don't understand your question.

@jdemeyer
Copy link

jdemeyer commented Aug 8, 2018

comment:7

In any case, if Singular wanted to make building with xalloc officially supported, they would have made a configure option for it. I don't think that we should be manually copying directories or whatever.

@jdemeyer
Copy link

jdemeyer commented Aug 8, 2018

comment:9

See also Singular/Singular#795

@jdemeyer
Copy link

jdemeyer commented Aug 8, 2018

Dependencies: #24735

@jdemeyer
Copy link

jdemeyer commented Aug 8, 2018

comment:11

By the way, simply using --disable-omalloc also doesn't work: Singular/Singular#534 (comment)

@jdemeyer jdemeyer removed this from the sage-8.4 milestone Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants