Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused "six" from mac app #26044

Closed
jdemeyer opened this issue Aug 10, 2018 · 7 comments
Closed

Delete unused "six" from mac app #26044

jdemeyer opened this issue Aug 10, 2018 · 7 comments

Comments

@jdemeyer
Copy link

There are two reasons why we should not have a copy of six in src/mac-app/tools/createDSStore/six.py:

  1. six is not actually used by the Mac App.

  2. We already ship six with Sage.

CC: @jhpalmieri

Component: build

Author: Jeroen Demeyer

Branch/Commit: 15e13d7

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/26044

@jdemeyer jdemeyer added this to the sage-8.4 milestone Aug 10, 2018
@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

New commits:

15e13d7Delete unused "six" from mac app

@jdemeyer
Copy link
Author

Commit: 15e13d7

@jhpalmieri
Copy link
Member

comment:3

This makes sense to me but I don't have time right now to really test it out: build the app and run it. I am not planning to test with https://github.com/sagemath/binary-pkg.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:4

Okay, it works for me.

@vbraun
Copy link
Member

vbraun commented Aug 25, 2018

Changed branch from u/jdemeyer/delete_unused__six__from_mac_app to 15e13d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants