Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of useless final ; in the doc of rings #26073

Closed
fchapoton opened this issue Aug 16, 2018 · 10 comments
Closed

get rid of useless final ; in the doc of rings #26073

fchapoton opened this issue Aug 16, 2018 · 10 comments
Labels
c: documentation p: minor / 4 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 18e66a5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26073
@fchapoton fchapoton added this to the sage-8.4 milestone Aug 16, 2018
@fchapoton
Copy link
Contributor Author

Branch: public/26073

@fchapoton
Copy link
Contributor Author

New commits:

db5229bget rid of useless final ; in doc of rings folder

@fchapoton
Copy link
Contributor Author

Commit: db5229b

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2018

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Aug 30, 2018

comment:3

merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 31, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

18e66a5Merge branch 'public/26073' in 8.4.b2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 31, 2018

Changed commit from db5229b to 18e66a5

@fchapoton
Copy link
Contributor Author

comment:5

trivial merge. Set back to positive

@vbraun
Copy link
Member

vbraun commented Sep 2, 2018

Changed branch from public/26073 to 18e66a5

@vbraun vbraun closed this as completed in 9b28597 Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton