Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of useless final ; in the doc of matrix #26075

Closed
fchapoton opened this issue Aug 16, 2018 · 10 comments
Closed

get rid of useless final ; in the doc of matrix #26075

fchapoton opened this issue Aug 16, 2018 · 10 comments

Comments

@fchapoton
Copy link
Contributor

and also take care of some bad line break there

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 3465dbe

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26075

@fchapoton fchapoton added this to the sage-8.4 milestone Aug 16, 2018
@fchapoton
Copy link
Contributor Author

New commits:

c1a49a2remove useless final ; and bad line breaks in doc of matrix folder

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26075

@fchapoton
Copy link
Contributor Author

Commit: c1a49a2

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2018

comment:2

Forgive (and feel free to ignore) the nitpick, but I would prefer

            sage: A = matrix(R,[[7*t^2 - t - 9, -1/4*t - 1, -17*t^2 - t + 1],
            ....:               [-t^2 + 1/4*t, t^2 + 5/7*t + 3, 1/5*t^2 + 1662],
            ....:               [-2*t - 3, 2*t^2 + 6*t - 1/2, -1/6*t^2]])
            sage: a = matrix(ZZ,4,[1, 0, 0, 0, 0, 1, 0, 0, 1,
            ....:                  -1, 1, 0, 1, -1, 1, 2]); a

as it is more in line with PEP8. Feel free to set to a positive review in either case.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

3465dbedetails in matrix2, and fix some notes and references there

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2018

Changed commit from c1a49a2 to 3465dbe

@fchapoton
Copy link
Contributor Author

comment:4

done

@tscrim
Copy link
Collaborator

tscrim commented Aug 17, 2018

comment:5

Thank you.

@vbraun
Copy link
Member

vbraun commented Sep 2, 2018

Changed branch from u/chapoton/26075 to 3465dbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants