Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up search_doc #26102

Closed
jhpalmieri opened this issue Aug 20, 2018 · 7 comments
Closed

Speed up search_doc #26102

jhpalmieri opened this issue Aug 20, 2018 · 7 comments
Labels
p: minor / 4 t: enhancement
Milestone
sage-8.4

Comments

@jhpalmieri
Copy link
Member

The function search_doc in sage/misc/sagedoc.py could be sped up: only search the html directory of local/share/doc/sage, and skip the _static subdirectories.

Component: misc

Author: John Palmieri

Branch/Commit: e837e5b

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/26102
@jhpalmieri jhpalmieri added this to the sage-8.4 milestone Aug 20, 2018
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/speed_up_search_doc

@jhpalmieri
Copy link
Member Author

New commits:

e837e5btrac 26102: speed up search_doc

@jhpalmieri
Copy link
Member Author

Commit: e837e5b

@jhpalmieri
Copy link
Member Author

comment:4

Some tests results on one computer (these obviously depend on the speed of the hard drive, among other things):

  • with 8.4.beta1 (devel): %time search_doc('curl') takes about 65 seconds.
  • with this branch: %time search_doc('curl') takes about 6 seconds.

@embray
Copy link
Contributor

embray commented Aug 23, 2018

Reviewer: Erik Bray

@embray
Copy link
Contributor

embray commented Aug 23, 2018

comment:5

Huge improvement!

@vbraun
Copy link
Member

vbraun commented Sep 3, 2018

Changed branch from u/jhpalmieri/speed_up_search_doc to e837e5b

@vbraun vbraun closed this as completed in e1f7b51 Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@embray @vbraun @jhpalmieri