Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some sorting issues in sage.homology (python3) #26166

Closed
jhpalmieri opened this issue Aug 30, 2018 · 6 comments
Closed

Fix some sorting issues in sage.homology (python3) #26166

jhpalmieri opened this issue Aug 30, 2018 · 6 comments
Labels
c: python3 p: minor / 4 t: enhancement
Milestone
sage-8.4

Comments

@jhpalmieri
Copy link
Member

For Python 3 compatibility, fix some sorting issues in doctests in the homology directory.

CC: @fchapoton @tscrim

Component: python3

Author: John Palmieri

Branch/Commit: 2bd717f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26166
@jhpalmieri jhpalmieri added this to the sage-8.4 milestone Aug 30, 2018
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/homology-sorting-py3

@jhpalmieri
Copy link
Member Author

Commit: 2bd717f

@jhpalmieri
Copy link
Member Author

New commits:

2bd717fminor sorting issues with sage.homology (for Python 3 compatibility)

@tscrim
Copy link
Collaborator

tscrim commented Aug 31, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 31, 2018

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 3, 2018

Changed branch from u/jhpalmieri/homology-sorting-py3 to 2bd717f

@vbraun vbraun closed this as completed in 5abe578 Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jhpalmieri