Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: trying not to sort the edges of graphs (step 1) #26169

Closed
fchapoton opened this issue Aug 31, 2018 · 12 comments
Closed

py3: trying not to sort the edges of graphs (step 1) #26169

fchapoton opened this issue Aug 31, 2018 · 12 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim @jm58660 @dcoudert @jhpalmieri

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 2f40188

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/26169
@fchapoton fchapoton added this to the sage-8.4 milestone Aug 31, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26169

@fchapoton
Copy link
Contributor Author

comment:1

Here is a modest tentative to enhance the situation. Let us see if there remains failing doctests.

New commits:

2f40188trying not to sort the edges (step 1)

@fchapoton
Copy link
Contributor Author

Commit: 2f40188

@fchapoton
Copy link
Contributor Author

comment:2

green bot, hourra !

@tscrim
Copy link
Collaborator

tscrim commented Sep 1, 2018

comment:3

I am okay with this change, but I am cc-ing a few other people who might have an opinion on this.

@dcoudert
Copy link
Contributor

dcoudert commented Sep 1, 2018

comment:4

I'm also OK with this change.

@jhpalmieri
Copy link
Member

comment:5

Sure, okay with me.

@fchapoton
Copy link
Contributor Author

comment:6

so, is this a positive review ?

@dcoudert
Copy link
Contributor

dcoudert commented Sep 2, 2018

comment:7

I'm currently compiling beta3 and will do some tests after that.

@dcoudert
Copy link
Contributor

dcoudert commented Sep 2, 2018

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

dcoudert commented Sep 2, 2018

comment:8

LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 3, 2018

Changed branch from u/chapoton/26169 to 2f40188

@vbraun vbraun closed this as completed in 21846b0 Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
5 participants
@vbraun @tscrim @jhpalmieri @fchapoton @dcoudert