Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of Baker's theorem for determination of differentials #26197

Closed
nbruin opened this issue Sep 6, 2018 · 10 comments
Closed

Fix use of Baker's theorem for determination of differentials #26197

nbruin opened this issue Sep 6, 2018 · 10 comments
Labels
c: geometry p: major / 3 t: bug
Milestone
sage-8.4

Comments

@nbruin
Copy link
Contributor

nbruin commented Sep 6, 2018

In sage.schemes.riemann_surfaces.riemann_surface.differential_basis_baker we need some further genericity check.

Component: geometry

Author: Nils Bruin

Branch/Commit: a0f77da

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26197
@nbruin nbruin added this to the sage-8.4 milestone Sep 6, 2018
@nbruin
Copy link
Contributor Author

nbruin commented Sep 6, 2018

Branch: u/nbruin/baker_differentials

@nbruin
Copy link
Contributor Author

nbruin commented Sep 6, 2018

comment:2

Code is fixed and test included.

New commits:

8bcc044trac 26197: fix use of Baker's theorem for differentials

@nbruin
Copy link
Contributor Author

nbruin commented Sep 6, 2018

Commit: 8bcc044

@nbruin
Copy link
Contributor Author

nbruin commented Sep 6, 2018

Author: Nils Bruin

@fchapoton
Copy link
Contributor

comment:3

for python3 compatibility, do not use .iteritems but .items

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

a0f77dapython3 compatibility

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2018

Changed commit from 8bcc044 to a0f77da

@fchapoton
Copy link
Contributor

comment:5

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Sep 8, 2018

Changed branch from u/nbruin/baker_differentials to a0f77da

@vbraun vbraun closed this as completed in d9778af Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @nbruin @fchapoton