Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate import of all_max_clique, max_clique and clique_number in global namespace #26200

Closed
dcoudert opened this issue Sep 6, 2018 · 14 comments

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Sep 6, 2018

As part of #25383, deprecate import of all_max_clique, max_clique and clique_number into global namespace. These methods are already methods of Graph.

Component: graph theory

Author: David Coudert

Branch/Commit: ab7d219

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26200

@dcoudert dcoudert added this to the sage-8.4 milestone Sep 6, 2018
@dcoudert
Copy link
Contributor Author

dcoudert commented Sep 6, 2018

comment:1

I don't understand the need for the following imports in src/sage/graphs/all.py

import sage.graphs.weakly_chordal
import sage.graphs.lovasz_theta
import sage.graphs.partial_cube

I let them here for now.


New commits:

f96220btrac #26200: remove methods from cliquer from global namespace

@dcoudert
Copy link
Contributor Author

dcoudert commented Sep 6, 2018

@dcoudert
Copy link
Contributor Author

dcoudert commented Sep 6, 2018

Commit: f96220b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2018

Changed commit from f96220b to aa37776

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

8d455d9trac #26200: fix doctests in cliquer
aa37776trac #26200: use lazy_import and add deprecation warning instead of brutal removal

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

ab7d219trac #26200: correct test message

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2018

Changed commit from aa37776 to ab7d219

@dcoudert

This comment has been minimized.

@dcoudert
Copy link
Contributor Author

dcoudert commented Sep 6, 2018

comment:4

Deprecation is better than brutal removal and consistent with #26196.

@dcoudert dcoudert changed the title Remove all_max_clique, max_clique and clique_number from global namespace deprecate import of all_max_clique, max_clique and clique_number in global namespace Sep 6, 2018
@dcoudert

This comment has been minimized.

@fchapoton
Copy link
Contributor

comment:6

ok, good to go

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@bryangingechen
Copy link
Mannequin

bryangingechen mannequin commented Sep 6, 2018

comment:7

For the other imports you asked about above; it seems they were all added when those modules were written, without any particular comment.

Was there some convention back then to add new modules to the global namespace?

@vbraun
Copy link
Member

vbraun commented Sep 8, 2018

Changed branch from u/dcoudert/26200_cliquer_and_namespace to ab7d219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants