Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix doctests for universal cyclotomic field #26207

Closed
fchapoton opened this issue Sep 7, 2018 · 8 comments
Closed

py3: fix doctests for universal cyclotomic field #26207

fchapoton opened this issue Sep 7, 2018 · 8 comments
Labels
c: python3 p: minor / 4 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

CC: @vinklein

Component: python3

Author: Frédéric Chapoton

Branch/Commit: e4a73fe

Reviewer: Vincent Klein

Issue created by migration from https://trac.sagemath.org/ticket/26207
@fchapoton fchapoton added this to the sage-8.4 milestone Sep 7, 2018
@fchapoton
Copy link
Contributor Author

Commit: e4a73fe

@fchapoton
Copy link
Contributor Author

New commits:

e4a73fepy3: make doctest pass in universal cyclotomic field

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26207

@vinklein vinklein mannequin self-assigned this Sep 7, 2018
@fchapoton
Copy link
Contributor Author

comment:3

For what is really happening here, see the discussion at the end of #24258

@vinklein
Copy link
Mannequin

vinklein mannequin commented Sep 7, 2018

comment:4

I will look at it immediately because yes your fix work but i didn't know why.

@vinklein
Copy link
Mannequin

vinklein mannequin commented Sep 7, 2018

comment:5

Ok i see. Looks good to me.

@vinklein
Copy link
Mannequin

vinklein mannequin commented Sep 7, 2018

Reviewer: Vincent Klein

@vinklein vinklein mannequin removed their assignment Sep 7, 2018
@vbraun
Copy link
Member

vbraun commented Sep 9, 2018

Changed branch from u/chapoton/26207 to e4a73fe

@vbraun vbraun closed this as completed in 058aa86 Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
2 participants
@vbraun @fchapoton