New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable hash for FreeMonoid_class #26221
Comments
Branch: u/jhpalmieri/free-monoid-hash |
Commit: |
New commits:
|
comment:3
Doctest failures (see patchbots):
The issue comes from the fact that |
Reviewer: Travis Scrimshaw |
comment:4
I think I would prefer to keep |
comment:5
Replying to @jhpalmieri:
You can absorb this behavior into the |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Okay, here is a branch using
Can you clarify? |
comment:8
Replying to @jhpalmieri:
Great, thank you. Small detail: the doc from
See the |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
Okay, how about this? (Independently, I realized the same thing about the docstrings, which is why I made that change almost immediately after your comment.) I also thought about just renaming |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:14
The docstrings still will not show in the I am okay with leaving the alias for now, but it should really be uniformized at some point. Yet, I've already asked quite a lot from you on this ticket. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:16
Okay, how about this? |
comment:17
Yep. LGTM. Thank you. |
Changed branch from u/jhpalmieri/free-monoid-hash to |
As in #26162 and other tickets, removing
__eq__
does the job. Also:UniqueRepresentation
instead ofUniqueFactory
for constructing instances ofFreeMonoid
.UniqueRepresentation
.Without this change, there are Python 3 doctest failures in
sage/algebras/lie_algebras
, among other places. For example,Part of #24551.
Component: python3
Author: John Palmieri
Branch/Commit:
8d3b505
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/26221
The text was updated successfully, but these errors were encountered: