Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor flint fixes #26252

Closed
dimpase opened this issue Sep 11, 2018 · 12 comments
Closed

minor flint fixes #26252

dimpase opened this issue Sep 11, 2018 · 12 comments

Comments

@dimpase
Copy link
Member

dimpase commented Sep 11, 2018

there is a place where it mixes CFLAGS with CXXFLAGS

see flintlib/flint#501 for the proposed upstream change

Upstream: Fixed upstream, in a later stable release.

CC: @slel @wbhart @lwhsu

Component: packages: standard

Keywords: flint

Author: Dima Pasechnik

Branch: 340cfaa

Reviewer: Li-Wen Hsu

Issue created by migration from https://trac.sagemath.org/ticket/26252

@dimpase dimpase added this to the sage-8.4 milestone Sep 11, 2018
@slel
Copy link
Member

slel commented Sep 11, 2018

Changed keywords from none to flint

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

afed27ddo not touch SunOS stuff here

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2018

Changed commit from eee6e04 to afed27d

@dimpase
Copy link
Member Author

dimpase commented Sep 12, 2018

Upstream: Reported upstream. No feedback yet.

@dimpase

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

340cfaado not touch SunOS here

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 12, 2018

Changed commit from afed27d to 340cfaa

@dimpase
Copy link
Member Author

dimpase commented Sep 12, 2018

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.

@lwhsu
Copy link

lwhsu commented Sep 12, 2018

Reviewer: Li-Wen Hsu

@vbraun
Copy link
Member

vbraun commented Sep 13, 2018

Changed branch from u/dimpase/flintCXXFLAGS to 340cfaa

@dimpase
Copy link
Member Author

dimpase commented Jan 21, 2019

comment:9

For the new FreeBSD 12.0, this fails, still, because the recognition of FreeBSD fails, and CXXFLAGS become a copy of CFLAGS (with std=c99, something that is an error on clang++ 6.0.1).

@dimpase
Copy link
Member Author

dimpase commented Jan 21, 2019

Changed commit from 340cfaa to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants