Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: hash for MPolynomial_polydict #26261

Closed
fchapoton opened this issue Sep 12, 2018 · 8 comments
Closed

py3: hash for MPolynomial_polydict #26261

fchapoton opened this issue Sep 12, 2018 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

part of #24551

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 1fe1188

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26261
@fchapoton fchapoton added this to the sage-8.4 milestone Sep 12, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26261

@fchapoton
Copy link
Contributor Author

New commits:

1fe1188py3: hash for MPolynomial_polydict

@fchapoton
Copy link
Contributor Author

Commit: 1fe1188

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review (we are getting closer to the end of #24551 !)

@tscrim
Copy link
Collaborator

tscrim commented Sep 13, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 13, 2018

comment:3

LGTM.

@embray
Copy link
Contributor

embray commented Sep 14, 2018

comment:4

Thank you--turns out I had a different hash for this class in my python3 branch, but my version was wrong. This appears to work better for some cases that were otherwise failing!

@vbraun
Copy link
Member

vbraun commented Sep 14, 2018

Changed branch from u/chapoton/26261 to 1fe1188

@vbraun vbraun closed this as completed in 95bbe69 Sep 14, 2018
@fchapoton fchapoton mentioned this issue Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @fchapoton