Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup Cusps class over number field #26272

Closed
fchapoton opened this issue Sep 13, 2018 · 7 comments
Closed

cleanup Cusps class over number field #26272

fchapoton opened this issue Sep 13, 2018 · 7 comments
Labels
c: modular forms p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

  • use Parent and UniqueRepresentation

  • no custom cache, usual "cached_function"

  • pep cleanup

CC: @tscrim

Component: modular forms

Author: Frédéric Chapoton

Branch/Commit: 1a40b75

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26272
@fchapoton fchapoton added this to the sage-8.4 milestone Sep 13, 2018
@fchapoton
Copy link
Contributor Author

Commit: 1a40b75

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26272

@fchapoton
Copy link
Contributor Author

New commits:

1a40b75cleanup of Cusps class over number fields (Parent, UniqueRepr, pep8)

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Sep 14, 2018

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Sep 14, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Sep 15, 2018

Changed branch from u/chapoton/26272 to 1a40b75

@vbraun vbraun closed this as completed in 6f1c942 Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: modular forms p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton