Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated N method in element.pyx #26296

Closed
fchapoton opened this issue Sep 16, 2018 · 14 comments
Closed

removed deprecated N method in element.pyx #26296

fchapoton opened this issue Sep 16, 2018 · 14 comments

Comments

@fchapoton
Copy link
Contributor

from #13055

  • plus remove __div__ automethod, problematic in python3

  • plus a few other details

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 65b3f3e

Reviewer: Travis Scrimshaw, Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/26296

@fchapoton fchapoton added this to the sage-8.4 milestone Sep 16, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26296

@fchapoton
Copy link
Contributor Author

Commit: 570c963

@fchapoton
Copy link
Contributor Author

New commits:

ba118b7remove deprecated N method in element.pyx
570c963remove one import

@tscrim
Copy link
Collaborator

tscrim commented Sep 16, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 16, 2018

comment:2

So I am fine with everything except the __div__. I feel like for completeness it should be there. Would you be okay with kicking that down the road?

@jdemeyer
Copy link

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Jeroen Demeyer

@jdemeyer
Copy link

comment:3

__div__ is Python 2 only, so I don't mind removing it.

@tscrim
Copy link
Collaborator

tscrim commented Sep 17, 2018

comment:4

Okay.

@vbraun
Copy link
Member

vbraun commented Sep 19, 2018

comment:5
sage -t --long src/sage/structure/element.pyx  # 2 doctests failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 19, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

65b3f3etrac 26296 fixing doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 19, 2018

Changed commit from 570c963 to 65b3f3e

@fchapoton
Copy link
Contributor Author

comment:8

fixed

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2018

comment:9

Verified.

@vbraun
Copy link
Member

vbraun commented Sep 20, 2018

Changed branch from u/chapoton/26296 to 65b3f3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants