Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fixing doctest in programming tutorials #26309

Closed
fchapoton opened this issue Sep 19, 2018 · 7 comments
Closed

py3: fixing doctest in programming tutorials #26309

fchapoton opened this issue Sep 19, 2018 · 7 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 0485c98

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26309
@fchapoton fchapoton added this to the sage-8.4 milestone Sep 19, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26309

@fchapoton
Copy link
Contributor Author

New commits:

0485c98fixing doctests in programming tutorials

@fchapoton
Copy link
Contributor Author

Commit: 0485c98

@fchapoton
Copy link
Contributor Author

comment:2

green bot (morally), please review

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2018

comment:3

I am actually thinking it would be better to just do list(d) because that is what we would want people to do in code when they need a list from a dict.

@vbraun
Copy link
Member

vbraun commented Sep 21, 2018

Changed branch from u/chapoton/26309 to 0485c98

@vbraun vbraun closed this as completed in 1e48ad5 Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton