Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better normalization for fraction field elements - follow up #26339

Open
mkoeppe opened this issue Sep 22, 2018 · 4 comments
Open

Better normalization for fraction field elements - follow up #26339

mkoeppe opened this issue Sep 22, 2018 · 4 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Sep 22, 2018

This is a follow-up on #16268 (and #16993), where the following further improvements were suggested:

  • clearing denominators in the numerator and denominator instead of making the leading coefficient of the denominator monic when that makes sense (i.e., for printing, and perhaps for computations in nested rational function fields, but making it fast enough requires some work),
  • also normalizing the leading coefficients over non-fields where that makes sense (see also discussion at Broken fraction field of rational polynomial ring #16993).

Related:

CC: @tscrim @cheuberg @Etn40ff @sagetrac-jakobkroeker @bhutz @robertwb @rwst @sagetrac-emassop @JohnCremona @mezzarobba @saraedum

Component: commutative algebra

Issue created by migration from https://trac.sagemath.org/ticket/26339

@mkoeppe

This comment has been minimized.

@yuan-zhou
Copy link

comment:2

Unexpected (-1) factor in the numerator and denominator of a sage.rings.fraction_field_element.FractionFieldElement.

SageMath version 9.1.beta3.

sage: P.<a,b,c>=QQ[]
sage: f = 1/a/(b-a)/(c-a)+1/b/(a-b)/(c-b)+1/c/(a-c)/(b-c); f
(-1)/(-a*b*c)
sage: f.numerator()
-1
sage: f.denominator()
-a*b*c

@mkoeppe mkoeppe modified the milestones: sage-8.4, sage-9.1 Mar 29, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 14, 2020

comment:4

pushing these forward to 9.2

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 29, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 13, 2021

comment:6

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants