MR1: Remove special case for Cygwin for BLAS detection when installing fflas_ffpack

[sagetrac-gitlab-bot]

<img src="https://secure.gravatar.com/avatar/c7d341e2b002754f2b21fbab3a3fd072?s=80&d=identicon" right, margin=5> Erik Bray (@embray) opened a merge request at https://gitlab.com/sagemath/sage/merge_requests/1:

We don't need this special case for Cygwin anymore. openblas and atlas packages should work without special-casing use of the netlib BLAS from Cygwin.

Component: porting: Cygwin

Author: Erik Bray

Branch/Commit: 09e289a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26353

[embray]

comment:3

First attempt at merge request synced from gitlab. A few bugs that happened (which for some reason didn't happen in testing):

1. The post back to gitlab with the link to the ticket did not succeed. Somehow a typo I didn't have in testing crept in. I have already fixed that.

2. For reasons I'm not sure, the ticket was created in an invalid state instead of "new". In fact, the ticket should probably created and immediately set to "needs_review".

The rest seemed to work OK. It will be good to have a mechanism to set other fields such as component and type, but for now I don't have a mechanism for that and instead assume it should be left up to project maintainers to set those fields.

[sagetrac-gitlab-bot]

Changed commit from baa351b to 09e289a

[sagetrac-gitlab-bot]

comment:4

New commits added to merge request. I updated the commit SHA-1. This was a forced push. New commits:

09e289a

we don't need this special case for Cygwin anymore

[tscrim]

comment:5

You probably want a mechanism to set the real name in the authors field too as otherwise this ticket will get reverted back from a positive review. Should I do the review from the gitlab side or from the Sage side?

[embray]

comment:6

Replying to @tscrim:

You probably want a mechanism to set the real name in the authors field too as otherwise this ticket will get reverted back from a positive review.

That's a good point. The names would have to match up though (or, I suppose, the release manager can always update the "trusted names" list.

Should I do the review from the gitlab side or from the Sage side?

Whichever you prefer.

[embray]

Author: Erik Bray

[tscrim]

comment:8

LGTM.

[tscrim]

Reviewer: Travis Scrimshaw

[embray]

comment:9

Just deployed an update to the bot which should address all the issues raised in this initial test ticket :)

[vbraun]

Changed branch from u/galois/mrs/1/embray/cygwin/fflas_ffpack/simplify-blas to 09e289a