Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete MultichooseNK #26385

Closed
fchapoton opened this issue Oct 2, 2018 · 13 comments
Closed

delete MultichooseNK #26385

fchapoton opened this issue Oct 2, 2018 · 13 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

that was deprecated in #16473

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: ec35edb

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26385
@fchapoton fchapoton added this to the sage-8.4 milestone Oct 2, 2018
@fchapoton
Copy link
Contributor Author

Branch: Description

@tscrim
Copy link
Collaborator

tscrim commented Oct 2, 2018

comment:3

Bad branch name.

@fchapoton
Copy link
Contributor Author

New commits:

0e88358get rid of multichoose_nk

@fchapoton
Copy link
Contributor Author

Commit: 0e88358

@fchapoton
Copy link
Contributor Author

Changed branch from Description to u/chapoton/26385

@fchapoton
Copy link
Contributor Author

comment:5

sorry, fixed

@tscrim
Copy link
Collaborator

tscrim commented Oct 3, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 3, 2018

comment:6

LGTM.

@fchapoton
Copy link
Contributor Author

comment:7

doc does not build

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 3, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

ec35edbremove multichoose_nk from the doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 3, 2018

Changed commit from 0e88358 to ec35edb

@fchapoton
Copy link
Contributor Author

comment:9

fixed

New commits:

ec35edbremove multichoose_nk from the doc

@vbraun
Copy link
Member

vbraun commented Oct 4, 2018

Changed branch from u/chapoton/26385 to ec35edb

@vbraun vbraun closed this as completed in a57eb8e Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton