py3: partial cure for multiset_partition_into_sets_ordered

[fchapoton]

which behaves very badly with python3... :(

Component: python3

Author: Frédéric Chapoton

Branch/Commit: a4921a4

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26391

[fchapoton]

Branch: u/chapoton/26391

[fchapoton]

Commit: d13b97b

[fchapoton]

New commits:

d13b97b

py3: partial fix for multiset partitions

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:2

Sorry about having to make you fix those things by not catching them on review.

[vbraun]

comment:3

On OSX:

**********************************************************************
File "src/sage/combinat/multiset_partition_into_sets_ordered.py", line 2003, in sage.combinat.multiset_partition_into_sets_ordered.OrderedMultisetPartitionsIntoSets_all_constraints._repr_
Failed example:
    OrderedMultisetPartitionsIntoSets(min_length=3, max_order=5, alphabet=[1,'a'])
Expected:
    Ordered Multiset Partitions into Sets with constraints:
     alphabet={1, 'a'}, max_order=5, min_length=3
Got:
    Ordered Multiset Partitions into Sets with constraints: alphabet={'a', 1}, max_order=5, min_length=3
**********************************************************************
1 item had failures:
   1 of   3 in sage.combinat.multiset_partition_into_sets_ordered.OrderedMultisetPartitionsIntoSets_all_constraints._repr_
    [570 tests, 1 failure, 32.46 s]
----------------------------------------------------------------------
sage -t --long src/sage/combinat/multiset_partition_into_sets_ordered.py  # 1 doctest failed
----------------------------------------------------------------------

[tscrim]

comment:4

I missed this before, but this A = sorted(cdict["alphabet"]) will break on Python3 in the test above.

[tscrim]

comment:5

Probably what needs to be done is

if not all(l in ZZ for l in cdict["alphabet"]):
    A = sorted(cdict["alphabet"], key=str)
else:
    A = sorted(cdict["alphabet"]

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ad09b20	Merge branch 'u/chapoton/26391' in 8.4.rc0
a4921a4	trac 26391 one fix

[sagetrac-git]

Changed commit from d13b97b to a4921a4

[tscrim]

comment:8

Thanks. LGTM.

[vbraun]

Changed branch from u/chapoton/26391 to a4921a4

[embray]

comment:10

This should be re-targeted for 8.5.