Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated code in continued fractions #26393

Closed
fchapoton opened this issue Oct 3, 2018 · 8 comments
Closed

remove deprecated code in continued fractions #26393

fchapoton opened this issue Oct 3, 2018 · 8 comments
Labels
c: algebra p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@fchapoton
Copy link
Contributor

after #14567

CC: @videlec

Component: algebra

Author: Frédéric Chapoton

Branch/Commit: 188f3e9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26393
@fchapoton fchapoton added this to the sage-8.4 milestone Oct 3, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26393

@fchapoton
Copy link
Contributor Author

Commit: 07d6a3b

@fchapoton
Copy link
Contributor Author

New commits:

07d6a3bremove deprecated code in continued fractions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 3, 2018

Changed commit from 07d6a3b to 188f3e9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 3, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

188f3e9fixing imports

@tscrim
Copy link
Collaborator

tscrim commented Oct 3, 2018

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 3, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 4, 2018

Changed branch from u/chapoton/26393 to 188f3e9

@vbraun vbraun closed this as completed in 6b3bfd6 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton