Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: allow Python 3 bytes to be multiplied by Sage Integers #26397

Closed
embray opened this issue Oct 4, 2018 · 5 comments
Closed

py3: allow Python 3 bytes to be multiplied by Sage Integers #26397

embray opened this issue Oct 4, 2018 · 5 comments
Labels
c: python3 p: minor / 4 t: bug
Milestone
sage-8.4

Comments

@embray
Copy link
Contributor

embray commented Oct 4, 2018

This already works on Python 2 with all basestring types, but needs an extra bit for Python 3 bytes. Noticed this while hacking on #24852.

Component: python3

Author: Erik Bray

Branch/Commit: 402ac35

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26397
@embray embray added this to the sage-8.4 milestone Oct 4, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

402ac35py3: allow multiplication of Python 3 bytes objects by Integers

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2018

Commit: 402ac35

@fchapoton
Copy link
Contributor

comment:3

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Oct 5, 2018

Changed branch from u/embray/python3/bytes-integer-mul to 402ac35

@vbraun vbraun closed this as completed in e1b3453 Oct 5, 2018
@jdemeyer jdemeyer mentioned this issue Oct 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: minor / 4 t: bug
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@embray @vbraun @fchapoton