Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean matchpoly.pyx #26439

Closed
dcoudert opened this issue Oct 9, 2018 · 7 comments
Closed

clean matchpoly.pyx #26439

dcoudert opened this issue Oct 9, 2018 · 7 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Oct 9, 2018

Clean the file, remove useless variables, and add key argument to a sort.

CC: @tscrim @fchapoton

Component: graph theory

Author: David Coudert

Branch/Commit: 43bab30

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26439
@dcoudert dcoudert added this to the sage-8.4 milestone Oct 9, 2018
@dcoudert
Copy link
Contributor Author

dcoudert commented Oct 9, 2018

Branch: public/26439_matchpoly

@dcoudert
Copy link
Contributor Author

dcoudert commented Oct 9, 2018

New commits:

43bab30trac #26439: clean and fix a sort

@dcoudert
Copy link
Contributor Author

dcoudert commented Oct 9, 2018

Commit: 43bab30

@tscrim
Copy link
Collaborator

tscrim commented Oct 9, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 9, 2018

comment:2

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 20, 2018

Changed branch from public/26439_matchpoly to 43bab30

@vbraun vbraun closed this as completed in 30649e2 Oct 20, 2018
@embray
Copy link
Contributor

embray commented Oct 28, 2018

comment:4

This should be re-targeted for 8.5.

@embray embray modified the milestones: sage-8.4, sage-8.5 Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @dcoudert