Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean lovasz_theta, isgci, independent_set #26446

Closed
dcoudert opened this issue Oct 9, 2018 · 18 comments
Closed

clean lovasz_theta, isgci, independent_set #26446

dcoudert opened this issue Oct 9, 2018 · 18 comments

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Oct 9, 2018

Clean files lovasz_theta.py, isgci.py and independent_set. Alignments, PEP8, etc.

Component: graph theory

Author: David Coudert

Branch/Commit: f697547

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26446

@dcoudert dcoudert added this to the sage-8.4 milestone Oct 9, 2018
@dcoudert
Copy link
Contributor Author

dcoudert commented Oct 9, 2018

Commit: 36081b6

@dcoudert
Copy link
Contributor Author

dcoudert commented Oct 9, 2018

New commits:

9d62c0dlovasz_theta.py and linearextensions.py
f27ec62isgci
36081b6idependent_set.pyx

@dcoudert
Copy link
Contributor Author

dcoudert commented Oct 9, 2018

Branch: public/26446_cleaning

@mantepse
Copy link
Contributor

mantepse commented Oct 9, 2018

comment:2

note that linearextensions.py is essentially removed in #25864.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

cdc9ccdtrac #26446: revert changes in linearextensions.py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2018

Changed commit from 36081b6 to cdc9ccd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

136f29ctrac #26446: revert changes in linearextensions.py (2)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2018

Changed commit from cdc9ccd to 136f29c

@dcoudert
Copy link
Contributor Author

dcoudert commented Oct 9, 2018

comment:5

Thanks for the information. I have reverted the changes in this file to avoid conflicts.

@dcoudert

This comment has been minimized.

@dcoudert dcoudert changed the title clean lovasz_theta, linearextensions, isgci, independent_set clean lovasz_theta, isgci, independent_set Oct 9, 2018
@mantepse
Copy link
Contributor

mantepse commented Oct 9, 2018

comment:6

That's very kind! Thank you!

@dcoudert dcoudert modified the milestones: sage-8.4, sage-8.5 Oct 18, 2018
@tscrim
Copy link
Collaborator

tscrim commented Oct 23, 2018

comment:8

This is one of those (annoying) long error messages with multiple sentences that needs leading capitalization and period:

-            raise ValueError("The given class id does not exist in the ISGCI database. Is the db too old ? You can update it with graph_classes.update_db().")
+            raise ValueError("the given class id does not exist in the ISGCI database. Is the db too old ? You can update it with graph_classes.update_db()")

However, this one should not have a period:

raise ValueError(str(I) + " is not a vertex of the graph.")

@tscrim
Copy link
Collaborator

tscrim commented Oct 23, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2018

Changed commit from 136f29c to f697547

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

fa4a15ftrac #26446: Merged with 8.5.beta0
f697547trac #26446: fix error messages

@dcoudert
Copy link
Contributor Author

comment:10

Corrected.

@tscrim
Copy link
Collaborator

tscrim commented Oct 24, 2018

comment:11

Thanks.

@vbraun
Copy link
Member

vbraun commented Oct 25, 2018

Changed branch from public/26446_cleaning to f697547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants