Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated zero_element #26456

Closed
fchapoton opened this issue Oct 10, 2018 · 9 comments
Closed

remove deprecated zero_element #26456

fchapoton opened this issue Oct 10, 2018 · 9 comments
Labels
c: algebra p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

after #17694

Component: algebra

Author: Frédéric Chapoton

Branch/Commit: 158aa66

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26456
@fchapoton fchapoton added this to the sage-8.4 milestone Oct 10, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26456

@fchapoton
Copy link
Contributor Author

Commit: 3a7279a

@fchapoton
Copy link
Contributor Author

New commits:

3a7279aremoved deprecated zero_element after #17694

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 10, 2018

Changed commit from 3a7279a to 158aa66

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 10, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

158aa66trac 26456 fix doctest

@tscrim
Copy link
Collaborator

tscrim commented Oct 10, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 10, 2018

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 20, 2018

Changed branch from u/chapoton/26456 to 158aa66

@vbraun vbraun closed this as completed in 91cd66d Oct 20, 2018
@embray
Copy link
Contributor

embray commented Oct 28, 2018

comment:5

This should be re-targeted for 8.5.

@embray embray modified the milestones: sage-8.4, sage-8.5 Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @fchapoton