Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine the category of Symmetric groups #26476

Closed
fchapoton opened this issue Oct 12, 2018 · 12 comments
Closed

refine the category of Symmetric groups #26476

fchapoton opened this issue Oct 12, 2018 · 12 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

as they are irreducible as reflection groups

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 1040965

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26476
@fchapoton fchapoton added this to the sage-8.4 milestone Oct 12, 2018
@fchapoton
Copy link
Contributor Author

New commits:

bdf4cferefine the category of Symmetric Groups (they are irreducible refl. groups)

@fchapoton
Copy link
Contributor Author

Commit: bdf4cfe

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26476

@tscrim
Copy link
Collaborator

tscrim commented Oct 12, 2018

comment:2

LGTM. You can switch to positive when the patchbot comes back green.

@tscrim
Copy link
Collaborator

tscrim commented Oct 12, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 12, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

1040965adding a doctest for noncrossing partitions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 12, 2018

Changed commit from bdf4cfe to 1040965

@fchapoton
Copy link
Contributor Author

comment:4

oh, sorry, you were too quick. I just added a doctest on noncrossing partitions, that was my motivation.

@fchapoton
Copy link
Contributor Author

comment:5

ok, patchbot is green. Do you agree with the added doctest ?

@tscrim
Copy link
Collaborator

tscrim commented Oct 12, 2018

comment:6

Yep, LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 20, 2018

Changed branch from u/chapoton/26476 to 1040965

@vbraun vbraun closed this as completed in 2fbf0a8 Oct 20, 2018
@embray
Copy link
Contributor

embray commented Oct 28, 2018

comment:8

This should be re-targeted for 8.5.

@embray embray modified the milestones: sage-8.4, sage-8.5 Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @fchapoton