Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padic printer does not support latex names #26479

Closed
xcaruso opened this issue Oct 12, 2018 · 17 comments
Closed

padic printer does not support latex names #26479

xcaruso opened this issue Oct 12, 2018 · 17 comments

Comments

@xcaruso
Copy link
Contributor

xcaruso commented Oct 12, 2018

sage: K.<pi> = Qp(2).extension(x^3 - 2)
sage: latex(pi)
'pi + O(pi^61)'

CC: @roed314

Component: padics

Author: Xavier Caruso

Branch/Commit: fb3bbaa

Reviewer: David Roe, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26479

@xcaruso xcaruso added this to the sage-8.4 milestone Oct 12, 2018
@xcaruso
Copy link
Contributor Author

xcaruso commented Oct 13, 2018

Branch: u/caruso/padic_printer_latex

@xcaruso
Copy link
Contributor Author

xcaruso commented Oct 13, 2018

Commit: 8b18164

@fchapoton
Copy link
Contributor

comment:2

Please undo all changes from \ZZ to \Bold{Z} in the documentation.

For the uniformity of sage documentation, it is better to always use \ZZ.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 19, 2018

Changed commit from 8b18164 to 008d7fc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 19, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

5ca2bd0Replace back \Bold{Z} by \ZZ, etc. in the documentation
83b48e3Replace \mathbb{Z}, \mathbb{Q} by \ZZ, \QQ respectively
008d7fcReplace \mathbb{f} by \Bold{F}

@xcaruso
Copy link
Contributor Author

xcaruso commented Oct 19, 2018

comment:4

Replying to @fchapoton:

Please undo all changes from \ZZ to \Bold{Z} in the documentation.

For the uniformity of sage documentation, it is better to always use \ZZ.

Ah OK. It's a kind of trap because we cannot use \ZZ in the notebook for instance.
Anyway, I made the changes and also replaced \mathbb{Z} by \ZZ, etc. Please tell me if it's not appropriate.

@fchapoton
Copy link
Contributor

comment:5

I think we also have \GF for finite fields. But all these cosmetic changes should really be done IMHO in another ticket, because they currently hide the important changes in this ticket, which get lost in the middle of all the changes made.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 19, 2018

Changed commit from 008d7fc to 9e85f91

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 19, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

e83713cRevert "Replace \mathbb{f} by \Bold{F}"
2e41efdRevert "Replace \mathbb{Z}, \mathbb{Q} by \ZZ, \QQ respectively"
9e85f91Small fixes

@xcaruso
Copy link
Contributor Author

xcaruso commented Oct 19, 2018

comment:7

OK, if you insist, I split this ticket into two parts.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

fb3bbaaFix doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2018

Changed commit from 9e85f91 to fb3bbaa

@roed314
Copy link
Contributor

roed314 commented Oct 25, 2018

comment:9

Looks good! I ran long tests and they pass.

@roed314
Copy link
Contributor

roed314 commented Oct 25, 2018

Reviewer: David Roe, Frédéric Chapoton

@roed314
Copy link
Contributor

roed314 commented Oct 25, 2018

Author: Xavier Caruso

@vbraun
Copy link
Member

vbraun commented Oct 26, 2018

Changed branch from u/caruso/padic_printer_latex to fb3bbaa

@embray
Copy link
Contributor

embray commented Oct 28, 2018

comment:11

This should be re-targeted for 8.5.

@embray embray modified the milestones: sage-8.4, sage-8.5 Oct 28, 2018
@xcaruso xcaruso mentioned this issue Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants