Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean graph_database.py #26483

Closed
dcoudert opened this issue Oct 13, 2018 · 7 comments
Closed

clean graph_database.py #26483

dcoudert opened this issue Oct 13, 2018 · 7 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@dcoudert
Copy link
Contributor

Clean the file and in particular the documentation of the module, classes and methods to improve html output.

CC: @tscrim

Component: graph theory

Author: David Coudert

Branch/Commit: cfcdde5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26483
@dcoudert dcoudert added this to the sage-8.4 milestone Oct 13, 2018
@dcoudert
Copy link
Contributor Author

Commit: cfcdde5

@dcoudert
Copy link
Contributor Author

New commits:

cfcdde5trac #26483: clean graph_database.py

@dcoudert
Copy link
Contributor Author

Branch: public/26483_graph_database_py

@dcoudert
Copy link
Contributor Author

comment:2

HELP HELP HELP

The pyflakes test raises a serious issue I don't know how to fix: method subgraphs_to_data is missing!!! I'm not sure what it should be. Help is more than welcome :P

@dcoudert dcoudert modified the milestones: sage-8.4, sage-8.5 Oct 18, 2018
@tscrim
Copy link
Collaborator

tscrim commented Oct 19, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 19, 2018

comment:4

This was a problem before this ticket and your changes do not change the situation, so the pyflakes error does not matter in this case.

@vbraun
Copy link
Member

vbraun commented Oct 20, 2018

Changed branch from public/26483_graph_database_py to cfcdde5

@vbraun vbraun closed this as completed in 9978e85 Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @dcoudert