Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(-1).sqrt(extend=False, all=True) raises an exception #26509

Closed
jdemeyer opened this issue Oct 19, 2018 · 7 comments
Closed

(-1).sqrt(extend=False, all=True) raises an exception #26509

jdemeyer opened this issue Oct 19, 2018 · 7 comments
Labels
c: basic arithmetic p: major / 3 t: bug
Milestone
sage-8.5

Comments

@jdemeyer
Copy link

In general, N.sqrt(extend=False, all=True) should never raise an exception if N is not a square. Instead, it should just return an empty list.

We also fix 0.sqrt(prec=53) which should return a real instead of an integer.

CC: @tscrim

Component: basic arithmetic

Author: Jeroen Demeyer

Branch/Commit: 880b0b5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26509
@jdemeyer jdemeyer added this to the sage-8.5 milestone Oct 19, 2018
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/__1__sqrt_extend_false__all_true__raises_an_exception

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Commit: 880b0b5

@jdemeyer
Copy link
Author

New commits:

880b0b5Various fixes to Integer.sqrt()

@tscrim
Copy link
Collaborator

tscrim commented Nov 27, 2018

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Nov 27, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Nov 29, 2018

Changed branch from u/jdemeyer/__1__sqrt_extend_false__all_true__raises_an_exception to 880b0b5

@vbraun vbraun closed this as completed in 2d41cc8 Nov 29, 2018
@GiacomoPope GiacomoPope mentioned this issue Jan 23, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: basic arithmetic p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer