New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutable poset: remove default for breaking ties in topological sort #26526
Comments
Commit: |
New commits:
|
Author: Daniel Krenn |
Reviewer: Benjamin Hackl |
comment:3
I looked through the changes and they look good to me overall. Would it make sense to add another doctest (possibly with output marked as random) where no key is passed and thus no sorting happens? |
comment:4
Replying to @behackl:
I do not see much of a point adding such a test. |
comment:5
Replying to @dkrenn:
I was thinking about testing whether calling the method without a key still works -- but you are right, I also cannot think of a usecase for that. Good to go. |
Changed branch from u/dkrenn/repr-default-topological to |
At the moment
shells_topological
of a mutable poset breaks ties by means ofrepr
by default. However, mutable poset is a data structure and should not do this expensive operation by default, therefore this default should be removed which is the aim of this ticket.Note that this default was in mainly due to convenience reasons to have the results in the doctests always in the same order.
(Motivation: For my code/application, this improves the computation time by more than a factor 2.)
CC: @behackl
Component: asymptotic expansions
Author: Daniel Krenn
Branch/Commit:
fd98fc1
Reviewer: Benjamin Hackl
Issue created by migration from https://trac.sagemath.org/ticket/26526
The text was updated successfully, but these errors were encountered: