Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean c_graph.pyx #26568

Closed
dcoudert opened this issue Oct 27, 2018 · 12 comments
Closed

clean c_graph.pyx #26568

dcoudert opened this issue Oct 27, 2018 · 12 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@dcoudert
Copy link
Contributor

PEP8 cleaning of the file.

CC: @tscrim

Component: graph theory

Author: David Coudert

Branch/Commit: 859fea9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26568
@dcoudert dcoudert added this to the sage-8.5 milestone Oct 27, 2018
@dcoudert

This comment has been minimized.

Sign in to view
@dcoudert
Copy link
Contributor Author

New commits:

bffda26trac #26568: clean c_graph.pyx

@dcoudert
Copy link
Contributor Author

Commit: bffda26

@dcoudert
Copy link
Contributor Author

Branch: public/26568_c_graph_pyx

@tscrim
Copy link
Collaborator

tscrim commented Oct 27, 2018

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 27, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 28, 2018

comment:3

Merge conflict

@dcoudert
Copy link
Contributor Author

comment:4

I guess I have to wait until next beta as I don't see any merge conflict.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 2, 2018

Changed commit from bffda26 to 859fea9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 2, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

859fea9trac #26568: fix merge conflict with 8.5.beta2

@dcoudert
Copy link
Contributor Author

dcoudert commented Nov 2, 2018

comment:6

I fixed the merge conflict with 8.5.beta2

@vbraun
Copy link
Member

vbraun commented Nov 4, 2018

Changed branch from public/26568_c_graph_pyx to 859fea9

@vbraun vbraun closed this as completed in 70a5645 Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @dcoudert