Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some deprecated stuff in plot #26583

Closed
fchapoton opened this issue Oct 28, 2018 · 10 comments
Closed

remove some deprecated stuff in plot #26583

fchapoton opened this issue Oct 28, 2018 · 10 comments
Labels
c: graphics p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

after #7008

CC: @tscrim

Component: graphics

Author: Frédéric Chapoton

Branch/Commit: 566a95f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26583
@fchapoton fchapoton added this to the sage-8.5 milestone Oct 28, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26583

@fchapoton
Copy link
Contributor Author

Commit: 566a95f

@fchapoton
Copy link
Contributor Author

New commits:

566a95fremove some deprecated stuff in plot

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Oct 30, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 30, 2018

comment:3

LGTM.

@fchapoton
Copy link
Contributor Author

comment:4

Thanks a lot, Travis and all my apologies for pestering you so often..

@tscrim
Copy link
Collaborator

tscrim commented Oct 30, 2018

comment:5

No problem. These reviews are easy (thanks to the patchbot). <sup>_</sup>

@kcrisman
Copy link
Member

comment:6

Huh, in the intervening nine years I guess I forgot about this completely :P but nice work finally removing it :-)

@vbraun
Copy link
Member

vbraun commented Oct 31, 2018

Changed branch from u/chapoton/26583 to 566a95f

@vbraun vbraun closed this as completed in 4120e2b Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graphics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
4 participants
@vbraun @tscrim @kcrisman @fchapoton