Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: make all tests in src/sage/tensor passed #26601

Closed
man74cio mannequin opened this issue Oct 30, 2018 · 6 comments
Closed

py3: make all tests in src/sage/tensor passed #26601

man74cio mannequin opened this issue Oct 30, 2018 · 6 comments
Labels
c: geometry c: python3 p: major / 3 t: bug
Milestone
sage-8.5

Comments

@man74cio
Copy link
Mannequin

man74cio mannequin commented Oct 30, 2018

The parallelisation of the function a.__mul__(a) in src/sage/tensor/modules/comp.py was only one test failing with python3 in src/sage/tensor.
Previously, with python2.7, to create the partial result we used
a list comprehension but now it fails.
We have to replace it with a for loop.

CC: @egourgoulhon @fchapoton @tscrim

Component: geometry

Keywords: @parallel, pickle

Author: Marco Mancini

Branch/Commit: 2a481f1

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/26601
@man74cio man74cio mannequin added this to the sage-8.5 milestone Oct 30, 2018
@man74cio man74cio mannequin added p: major / 3 labels Oct 30, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2018

Changed commit from fbf07a6 to 2a481f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

2a481f1Changed name

@egourgoulhon

This comment has been minimized.

Sign in to view
@egourgoulhon egourgoulhon changed the title Make all doctests in tensor/modules passed with Python 3 py3: make all tests in src/sage/tensor passed Oct 30, 2018
@man74cio man74cio mannequin added the s: needs review label Oct 30, 2018
@egourgoulhon
Copy link
Member

comment:4

Thank you Marco!

I've checked the changes with both Python2 and Python3.
In particular, with Python3, sage -tp --long src/sage/tensor/ returns now "All tests passed!".

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@vbraun
Copy link
Member

vbraun commented Oct 31, 2018

Changed branch from public/manifolds/To_python3_parellisation_prob_in_tensor_comp to 2a481f1

@vbraun vbraun closed this as completed in fd19ff3 Oct 31, 2018
@egourgoulhon egourgoulhon mentioned this issue Apr 14, 2022
Closed
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry c: python3 p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
2 participants
@vbraun @egourgoulhon