Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some magma/groebner log failing doctests #26605

Closed
fchapoton opened this issue Oct 30, 2018 · 5 comments
Closed

fix some magma/groebner log failing doctests #26605

fchapoton opened this issue Oct 30, 2018 · 5 comments
Labels
c: interfaces: optional p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

that prevent the patchbot fermat to run smoothly

CC: @embray @jdemeyer @tscrim @kiwifb @vbraun

Component: interfaces: optional

Author: Frédéric Chapoton

Branch/Commit: 4f9221a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26605
@fchapoton fchapoton added this to the sage-8.5 milestone Oct 30, 2018
@fchapoton
Copy link
Contributor Author

comment:2

Please review. This should be simple enough, and will be helpful for the patchbot.

@fchapoton
Copy link
Contributor Author

comment:4

green bot, and you can see that the fermat patchbot is happy, for the first time since many months..

@tscrim
Copy link
Collaborator

tscrim commented Nov 3, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 3, 2018

comment:5

Since I don't have magma, I cannot explicitly check, but given that fermat is green (since that has magma), I am going to put this as a positive review.

@vbraun
Copy link
Member

vbraun commented Nov 7, 2018

Changed branch from u/chapoton/magma_gb to 4f9221a

@vbraun vbraun closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces: optional p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton