Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: some care for division in range #26617

Closed
fchapoton opened this issue Nov 2, 2018 · 13 comments
Closed

py3: some care for division in range #26617

fchapoton opened this issue Nov 2, 2018 · 13 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: f9e0f89

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26617
@fchapoton fchapoton added this to the sage-8.5 milestone Nov 2, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26617

@fchapoton
Copy link
Contributor Author

New commits:

5a06901py3: some care for divisions in range

@fchapoton
Copy link
Contributor Author

Commit: 5a06901

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 2, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f01bce1py3: some care for divisions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 2, 2018

Changed commit from 5a06901 to f01bce1

@fchapoton
Copy link
Contributor Author

comment:3

failing doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

f9e0f89trac 26617 fix division in power of q

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2018

Changed commit from f01bce1 to f9e0f89

@fchapoton
Copy link
Contributor Author

comment:5

should be ok now

@fchapoton
Copy link
Contributor Author

comment:6

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Nov 5, 2018

comment:8

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Nov 5, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Nov 7, 2018

Changed branch from u/chapoton/26617 to f9e0f89

@vbraun vbraun closed this as completed in 6508f6d Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton